Added isSessionExpired() method #31. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dnl-blkv all yours 👀 |
dnl-blkv
suggested changes
Oct 24, 2017
| # Endpoints not requiring active session for the request to succeed. | ||
| _URL_DEVICE_SERVER = 'device-server' | ||
| _URI_INSTALLATION = 'installation' | ||
| _URI_SESSION_SERVER = 'session-server' |
There was a problem hiding this comment.
Please put these constants after the map (just like we do in PHP).
There was a problem hiding this comment.
That won't work in python 😅 ?
https://stackoverflow.com/questions/1590608/is-it-possible-to-forward-declare-a-function-in-python
There was a problem hiding this comment.
Ahh, you're right! My apologies.
There was a problem hiding this comment.
python is not that magical ✨ 😂
There was a problem hiding this comment.
@OGKevin declare time mixed with run time? Tell me it is not magical :P
| @@ -93,7 +103,8 @@ def _request(self, method, uri_relative, request_bytes, params, | |||
|
|
|||
| uri_relative_with_params = self._append_params_to_uri(uri_relative, | |||
| params) | |||
| self._api_context.ensure_session_active() | |||
| if uri_relative not in self._URIS_NOT_REQUIRING_ACTIVE_SESSION: | |||
| self._api_context.ensure_session_active() | |||
There was a problem hiding this comment.
Please add a newline after the if body! :)
bunq/sdk/context.py
Outdated
|
|
||
| def is_session_active(self): | ||
| """ | ||
| :return: True if it has expired, otherwise false |
There was a problem hiding this comment.
Please kill this return part: the method is quite obvious!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#31
What has been done
This pr introduces a new way to handle
SessionContext. Now it is possible to do the following:This way there is no saving an unchanged context.
Closes #31