Feature/callback models bunq/sdk python#40 #43
Conversation
bunq/sdk/json/adapters.py
Outdated
| :type field: str | ||
| :type obj: dict | ||
|
|
||
| :return: None|dict |
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Please add terminating newline.
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Please add terminating newline.
| base_path = os.path.dirname(__file__) | ||
| file_path = os.path.abspath(os.path.join(base_path, file_path)) | ||
|
|
||
| with open(file_path, 'r') as f: |
There was a problem hiding this comment.
Oops, just noticed: 'r' is magic! Please make a constant :D
| self.assertIsNotNone(expected_model) | ||
| self.assertIsNotNone(referenced_model) | ||
| self.assertTrue( | ||
| self.assertInstanceOfReferencedObject( |
There was a problem hiding this comment.
this should not be called "assert..." but just "is...", because it is not throwing any errors!
| class_name | ||
| ) | ||
| or | ||
| self.assertInstanceOfReferencedEndpoint( |
There was a problem hiding this comment.
this should not be called "assert..." but just "is...", because it is not throwing any errors!
There was a problem hiding this comment.
actually these two methods can be combined to one method, such as: isModelReference
There was a problem hiding this comment.
Then, the content of isModelReference would me something like:
def isModelReference(referenced_model, class_name):
modelClass = getModelClassOrNone(class_name)
if modelClass is None:
return False
return isinstance(referenced_model, modelClass)
and then
def getModelClassOrNone(class_name):
if hasattr(object_, class_name):
return getattr(object_, class_name)
if hasattr(endpoint, class_name):
return getattr(endpoint, class_name)
if hasattr(core, class_name):
return getattr(core, class_name)
return None
The second method could also be reworked to loop through a constant array of modules and return None if nothing was found in the array.
There was a problem hiding this comment.
And don't forget to add the docstring with argument and return types please! :D
| json_string = f.read() | ||
| json_object = json.loads(json_string) | ||
| json_string = json.dumps(json_object[ | ||
| self._KEY_NOTIFICATION_URL_MODEL |
There was a problem hiding this comment.
since we've started... %)
here I'd prefer to have it formatted like this:
json_string = json.dumps(
json_object[self._KEY_NOTIFICATION_URL_MODEL]
)
Because it is an object element access rather than an array definition, and multi-line approach seems highly odd here.
Closes #40
Closes #44