Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openbox/menu.xml: paths to some helpfiles are wrong #42

Closed
ghost opened this issue May 8, 2016 · 5 comments
Closed

openbox/menu.xml: paths to some helpfiles are wrong #42

ghost opened this issue May 8, 2016 · 5 comments
Labels

Comments

@ghost
Copy link

ghost commented May 8, 2016

Attached fix in pull request #41.

Does the package index get refreshed for new BL installs before installation stuff to disk?

In any case, we should fix this ASAP because it's clearly user-facing.

@ghost ghost added the bug label May 8, 2016
@johnraff
Copy link
Member

johnraff commented May 9, 2016

Merged, changelog updated and tagged to 8.7.1-1

And thank you for catching this!

Does the package index get refreshed for new BL installs before installation stuff to disk?

You'll have to check with @hhhorb but AFAIK no. I think the packages are baked into the iso at the time it is built. A dynamic install of the bunsen-* packages from the BL repository at install time (like the netinstall) might conceivably be possible, but I don't know how a live session would work in that case - we'll have to discuss it with hhh. Maybe some post-install trigger to run apt-get update/upgrade?

The first run of bl-welcome will bring in the new bunsen-configs, but the patch will go into the file in skel/. Users will still have to edit their personal copy of menu.xml, or initiate an overwrite of their config files by deleting ~/.config/bunsen/bl-setup and logging out/in.

We just have to be super-careful to minimize changes to the template user config files in skel. It's unfortunate that this bug got through just before the official release. (Luckily the paths in the "help" submenu are OK.)

@ghost
Copy link
Author

ghost commented May 9, 2016

Uusually, when installing Debian via netinstall, it will update the package index and download the latest packages of the base system before installing. I'm not familiar how the Debian installer and live environments work in that regard however, that's why I was asking. No problem as long as we deploy the symlink IMO.

@johnraff
Copy link
Member

johnraff commented May 9, 2016

Right, the symlink (bunsen-docs>bunsen) takes effect immediately and needs no user action.
bunsen-docs 8.1-2 now on GitHub.

@ghost
Copy link
Author

ghost commented May 9, 2016

Both changes are deployed to the repos.

@ghost ghost closed this as completed May 9, 2016
@johnraff
Copy link
Member

johnraff commented May 10, 2016

Thanks!
And apologies for that careless oversight.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant