Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D keypoint network implementation {Minderer et al. 2019} #3

Closed
mch5048 opened this issue Mar 23, 2022 · 2 comments
Closed

2D keypoint network implementation {Minderer et al. 2019} #3

mch5048 opened this issue Mar 23, 2022 · 2 comments

Comments

@mch5048
Copy link

mch5048 commented Mar 23, 2022

Hi, thanks for sharing this awesome work to our community!

In the paper, authors compare the proposed method with 2D keypoint representation, which is originally proposed by
Minderer et al. 2019.

While investigating the code implementation, I got confused by the '2D' argument of the keypoint-based PPO algorithm.
Is parsing with '2D' argument instantiates the representation learning proposed by Minderer et al. or just the 2D fraction of this work?
From the code, it seems the 2D version of the keypoint network is not related to that of Minderer et al.

Thanks for your help in advance!

@buoyancy99
Copy link
Owner

2D version here refers to learning keypoints via the method specified by the box "Keypoint Detector" in Figure 1 of Minderer et al. 2019

The parts outside the "Keypoint Detector" is discarded as they are used for dynamics instead of keypoint learning.

Please close the issue if the above explanation answers your question. If you have further questions, I prefer communication through emails. Github issue page should reserved for questions about code.

@mch5048
Copy link
Author

mch5048 commented Mar 24, 2022

Thanks for quick response. Now I understand the code architecture. I'll close this issue and contact you via email if I encounter further questions. Thanks again.

@mch5048 mch5048 closed this as completed Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants