Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rfr] edeaR processing_time(), throughput_time(), idle_time() units arg #36

Merged
merged 57 commits into from
Sep 25, 2022

Conversation

gerardvanhulzen
Copy link
Contributor

Set units of output according to difftime units from output (useful in case the user set units = "auto")

gerardvanhulzen and others added 30 commits June 28, 2022 13:12
Both functions would benefit some future refactoring.
@codecov-commenter
Copy link

Codecov Report

Base: 0.00% // Head: 6.34% // Increases project coverage by +6.34% 🎉

Coverage data is based on head (d36ba77) compared to base (8f89292).
Patch coverage: 10.35% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##             dev     #36      +/-   ##
========================================
+ Coverage   0.00%   6.34%   +6.34%     
========================================
  Files        137     132       -5     
  Lines       4375    4999     +624     
========================================
+ Hits           0     317     +317     
- Misses      4375    4682     +307     
Impacted Files Coverage Δ
R/activity_frequency.R 0.00% <0.00%> (ø)
R/activity_presence.R 0.00% <0.00%> (ø)
R/augment.R 0.00% <0.00%> (ø)
R/calculate_queuing_length.R 0.00% <ø> (ø)
R/calculate_queuing_times.R 0.00% <ø> (ø)
R/end_activities.R 0.00% <0.00%> (ø)
R/filter_activity.R 0.00% <0.00%> (ø)
R/filter_activity_frequency.R 0.00% <0.00%> (ø)
R/filter_activity_instance.R 0.00% <ø> (ø)
R/filter_activity_presence.R 0.00% <0.00%> (ø)
... and 113 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gertjanssenswillen gertjanssenswillen merged commit fff93ee into dev Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants