Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggestion for Lock #122

Closed
ShawnHsiung opened this issue Sep 8, 2021 · 1 comment
Closed

suggestion for Lock #122

ShawnHsiung opened this issue Sep 8, 2021 · 1 comment
Assignees
@buraksezer
Labels
enhancement New feature or request

Comments

@ShawnHsiung
Copy link
Contributor 

type LockContext struct {
	name  string
	key   string
	token []byte
	dmap  *DMap
}

May we add a Lease method for LockContext to update the expiry for the given Lock? It's not convenient for users to implement by themselves because of no exported field in LockContext.
@buraksezer buraksezer self-assigned this Sep 8, 2021
@buraksezer buraksezer added the enhancement New feature or request label Sep 8, 2021
@ShawnHsiung ShawnHsiung mentioned this issue Sep 9, 2021
Merged
@ShawnHsiung
Copy link
Contributor Author

hi @buraksezer , I sent a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@buraksezer buraksezer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ShawnHsiung @buraksezer