reduce pipeline allocations #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
The test error appears to be due to a flaky network, not related to this PR, but I don't have permission to re-run the test |
|
Thank you for your contributions @derekperkins. I'll take care of the flaky tests. |
|
No worries. I'm a maintainer of https://github.com/vitessio/vitess/, and we've got our fair share of flaky tests there. It's hard to test distributed systems :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Walking through the code, it seems to be clear that there is no reuse of the commands. As written, calls to
FutureXXXafter calling Discard would either return invalid data or panic, so this doesn't alter that undefined behavior.Resolves #203