New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Duplicate redis client leak #223

Merged

buraksezer merged 2 commits into buraksezer:release/v0.5.0 from robinbraemer:fixresourceleak

Mar 28, 2023

Contributor

robinbraemer commented Mar 28, 2023 •

edited

As soon as we RUnlock we must assume that clients was updated by another goroutine.
Failing to do so could overwrite the existing redis client in c.client[addr] and leak all its resources like the connection pool.
We should still use the RWMutex as the fast-path of func (c *Client) Get(addr string) *redis.Client

buraksezer and others added 2 commits

February 5, 2023 12:38


          chore: update README.md

45fac0f


          fix: Duplicate redis client leak

318319c

sonarcloud bot commented Mar 28, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

buraksezer changed the base branch from master to release/v0.5.0

March 28, 2023 22:14

buraksezer approved these changes

View reviewed changes

buraksezer merged commit 6d22536 into buraksezer:release/v0.5.0

6 checks passed

Owner

buraksezer commented Mar 28, 2023

Thank you for your contribution, @robinbraemer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment