Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CSV::parse with block #18

Open
buren opened this issue Jun 13, 2018 · 1 comment
Open

Use CSV::parse with block #18

buren opened this issue Jun 13, 2018 · 1 comment

Comments

@buren
Copy link
Owner

buren commented Jun 13, 2018

CSV::parse with block will yield each row of the CSV file. If we use that method we could get rid of the extra rows iteration that we need we now do to build the row objects.

Though in order for that to happen we need to update the internal interface of Matrix.

@buren
Copy link
Owner Author

buren commented Jul 1, 2018

After some initial, albeit very limited, testing it seemed to my surprise that it wasn't faster at all, but slower. (I must have made some other simple change during that PoC that caused that.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant