JavaScript modal dialogs (prompt, alert, etc) probably need to be memoized #25
Labels
Milestone
Comments
burg
pushed a commit
that referenced
this issue
Feb 14, 2013
https://bugs.webkit.org/show_bug.cgi?id=78454 Unreviewed. Rebaseline #25 of N. Chrome MAC rendering was previously incorrect, and still is incorrect/weird: update test_expectations.txt with IMAGE failure. * platform/chromium-linux/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed. * platform/chromium-linux/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed. * platform/chromium-mac-leopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added. * platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: * platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed. * platform/chromium-win-vista/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed. * platform/chromium-win-vista/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed. * platform/chromium-win-xp/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed. * platform/chromium-win-xp/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed. * platform/chromium-win/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed. * platform/chromium/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
|
This is fixed now, AFAIK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm not sure about this, but I would guess that our replayed user input actions will not correctly click through things like
window.alert. If this is the case, then we should memoize the results of these dialogs similarly to context menu ordocument.cookie. Memoization will make the dialog box not pop up on replay, but we don't have much choice if the dialogs are native (OS) elements.The text was updated successfully, but these errors were encountered: