fixing a few issues with UDF sanitization

burhan · Nov 3, 2014 · 2b7045e · 2b7045e
1 parent 4e5de78
commit 2b7045e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/HISTORY.rst b/HISTORY.rst
@@ -3,6 +3,13 @@
 History
 -------
 
+1.1.2 (2014-11-03)
+++++++++++++++++++
+
+* Fixed issue iterating over UDF dictionary keys
+* Fixed issue where unicode was being passed to sanitize
+  unicode strings are not allowed in UDF fields
+
 1.1 (2014-08-12)
 ++++++++++++++++
 

diff --git a/e24PaymentPipe/e24PaymentPipe.py b/e24PaymentPipe/e24PaymentPipe.py
@@ -67,11 +67,11 @@ def udf(self, value):
                 raise ValueError('Only 5 user defined fields (UDF) are allowed')
             if not all(x[:3].upper() == 'UDF' and 0 < int(x[-1]) <= 5 for x in value.keys()):
                 raise ValueError('Dictionary keys must be in the form of UDF1 through UDF5')
-            self._udf.update({k.upper(): sanitize(v) for k, v in value.iteritems()})
+            self._udf.update({k.upper(): sanitize(str(v)) for k, v in value.items()})
         except AttributeError:
             # Passed value does not have a keys() method,
             # assume its not a dictionary
-            self._udf.update({'UDF{}'.format(k + 1): sanitize(v) for k, v in enumerate(value)})
+            self._udf.update({'UDF{}'.format(k + 1): sanitize(str(v)) for k, v in enumerate(value)})
 
     @property
     def error_url(self):

diff --git a/setup.py b/setup.py
@@ -19,7 +19,7 @@
 
 setup(
     name='e24PaymentPipe',
-    version='1.1.1',
+    version='1.1.2',
     description="This package provides a Python implementation for ACI's e24PaymentPipe Merchant Gateway",
     long_description=readme + '\n\n' + history,
     author='Burhan Khalid',