Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to disable clearAllViews onSave #54

Closed
skined90 opened this issue Jun 13, 2018 · 5 comments
Closed

Add possibility to disable clearAllViews onSave #54

skined90 opened this issue Jun 13, 2018 · 5 comments
Assignees
Labels
enhancement New feature or request fixed the issue has been fixed

Comments

@skined90
Copy link

I have a process with a few steps of uploading image. First step is photo edit using this library and the second step is adding name of image. After saving photo all stickers disappear in scenario if I want to go back from screen where I'm adding name of an image. Is there possibility to add some flag should photoEditor should clear views or not on save?

@skined90 skined90 changed the title Add possibility to disable clearAllViews on back Add possibility to disable clearAllViews onSave Jun 13, 2018
@burhanrashid52
Copy link
Owner

Sorry for the late response. Depending upon the developer responses for this issue, we will look into for future releases.

@burhanrashid52 burhanrashid52 added the enhancement New feature or request label Jul 23, 2018
@burhanrashid52 burhanrashid52 self-assigned this Jul 23, 2018
@Sulfkain
Copy link

@burhanrashid52 I'm working on a modification to be able to avoid BitmapUtil.removeTransparency; and will be easy to add that kind of customization for clearAllViews too.
Will be merged if i put that change?
I will do with with flags as for ex. View.setSystemUiVisibility

@burhanrashid52
Copy link
Owner

Yeah sure. @Sulfkain
Create PR than will review the changes and if it works then I am happy to merge.

@Sulfkain
Copy link

Sulfkain commented Jul 31, 2018

Done @burhanrashid52 :)
Try everything works as expected

#71

@burhanrashid52 burhanrashid52 added the fixed the issue has been fixed label Aug 8, 2018
@burhanrashid52
Copy link
Owner

Resolved in v.0.3.2
For more details check Saving Wiki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed the issue has been fixed
Projects
None yet
Development

No branches or pull requests

3 participants