Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brush drawing issue #57

Closed
ervinod opened this issue Jun 14, 2018 · 12 comments
Closed

Brush drawing issue #57

ervinod opened this issue Jun 14, 2018 · 12 comments
Assignees
Labels
bug Something isn't working release.1.1.0

Comments

@ervinod
Copy link

ervinod commented Jun 14, 2018

Hello there,
Brush drawing is automatically removed from view when saving image
Please follow following scenario to detect bug:

  1. Draw something on screen using brush.
  2. Save Image (working correctly as expected)
  3. Add Sticker
  4. Save Image (working correctly as expected)
  5. Draw something on screen using brush
  6. Save Image (Bug)
    In saved image brush drawing that i have drawn on view in step 5 is not reflected. means when i click save button (step 6), the last added view i.e. brush is removed

Please check this issue and solve in next release

@ervinod
Copy link
Author

ervinod commented Jun 15, 2018

Hello there... have you checked this issue

@ervinod
Copy link
Author

ervinod commented Jun 16, 2018

@burhanrashid52 have u checked this issue ?

@ervinod
Copy link
Author

ervinod commented Jun 18, 2018

Hello there... have you checked this issue yet or not....
Please suggest me some logic/changes to solve this issue or tell the reason why this issue occures

@burhanrashid52 burhanrashid52 self-assigned this Jun 18, 2018
@burhanrashid52 burhanrashid52 added the bug Something isn't working label Jun 18, 2018
@burhanrashid52
Copy link
Owner

I was out of station for a week. Let me look into it

@ervinod
Copy link
Author

ervinod commented Jun 18, 2018

@burhanrashid52 Okay... Please check this issue when you get time

@ervinod
Copy link
Author

ervinod commented Jun 28, 2018

@burhanrashid52 hello there..... have you got any solution to resolve this bug ?

@burhanrashid52
Copy link
Owner

No, still I am not able to trace the bug. I am actively working on it. This happens with the brush only. It works fine with sticker and emojis.

@ervinod
Copy link
Author

ervinod commented Jun 29, 2018

Okay..... To resolve this bug i tried to save image in the way that is used in PhotoEditorSDK library , but i am failed to resolve the issue.....

@tusharSensovium
Copy link

I am also facing the same issue. Any suggestion?

@qlehong
Copy link

qlehong commented Aug 5, 2019

HI @ervinod Could you review and verify this pull request #181
for this bug? Thank you!

feko006 pushed a commit to feko006/PhotoEditor that referenced this issue May 20, 2020
…d resulting in inconsistent saved images.
@gurpreet433
Copy link

@qlehong thanks it is resolved by this :)

@tatraef
Copy link

tatraef commented Sep 6, 2020

I still have this error, changes from @qlehong have not been saved?

burhanrashid52 added a commit that referenced this issue Oct 19, 2020
#57 Fixed brush view drawing cache not being invalidated resulting in…
burhanrashid52 pushed a commit that referenced this issue Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release.1.1.0
Projects
None yet
Development

No branches or pull requests

6 participants