-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated README.md for Django 1.9+ #69
Conversation
1 similar comment
Django needed Mass Edit action to be added.
1 similar comment
Why is this method better than? django-mass-edit/massadmin/__init__.py Line 31 in 32e6dbe
Does that init thing no longer work from a Django change? |
Yeah it didn't work when I tried. |
I'd rather have the action just magically appear. Maybe try to figure out why it's not working for you and see if there is a alternative. |
Sounds good! Will make another PR, but for now I think the readme change is
necessary because it does not work out of the box at all with the new
django changes
…On Wed, Apr 19, 2017 at 17:47 David Burke ***@***.***> wrote:
I'd rather have the action just magically appear. Maybe try to figure out
why it's not working for you and see if there is a alternative.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#69 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE7GthXdT0bkZESRxUVJgsPGaHrWtXPNks5rxoDqgaJpZM4Mu3lL>
.
|
Besides, you need to add the urls anyway, so adding another line to the same file isn't really any different |
I'm against adding speculation on a project's readme. If you find a way to make it "just work" or a specific reason on why the "just works" method isn't working for you we could add it to the readme. For that I'd like to see documentation proving that Django does not allow apps adding admin actions automatically. If I had to guess - we probably just need to move the logic to somewhere like here. |
Added code to get django-mass-edit working on Django 1.9+