Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README.md for Django 1.9+ #69

Closed
wants to merge 5 commits into from

Conversation

namanshenoy
Copy link

Added code to get django-mass-edit working on Django 1.9+

@coveralls
Copy link

coveralls commented Mar 30, 2017

Coverage Status

Coverage remained the same at 89.231% when pulling c538e02 on namanshenoy:master into 999a66c on burke-software:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.231% when pulling c538e02 on namanshenoy:master into 999a66c on burke-software:master.

Django needed Mass Edit action to be added.
@coveralls
Copy link

coveralls commented Mar 30, 2017

Coverage Status

Coverage remained the same at 89.231% when pulling 6eac412 on namanshenoy:master into 999a66c on burke-software:master.

1 similar comment
@coveralls
Copy link

coveralls commented Mar 30, 2017

Coverage Status

Coverage remained the same at 89.231% when pulling 6eac412 on namanshenoy:master into 999a66c on burke-software:master.

@bufke
Copy link
Member

bufke commented Apr 19, 2017

Why is this method better than?

admin.site.add_action(mass_change_selected)

Does that init thing no longer work from a Django change?

@namanshenoy
Copy link
Author

Yeah it didn't work when I tried.
Might have something to do with template loaders.

@bufke
Copy link
Member

bufke commented Apr 19, 2017

I'd rather have the action just magically appear. Maybe try to figure out why it's not working for you and see if there is a alternative.

@namanshenoy
Copy link
Author

namanshenoy commented Apr 19, 2017 via email

@namanshenoy
Copy link
Author

Besides, you need to add the urls anyway, so adding another line to the same file isn't really any different

@bufke
Copy link
Member

bufke commented Apr 28, 2017

I'm against adding speculation on a project's readme. If you find a way to make it "just work" or a specific reason on why the "just works" method isn't working for you we could add it to the readme. For that I'd like to see documentation proving that Django does not allow apps adding admin actions automatically.

If I had to guess - we probably just need to move the logic to somewhere like here.

@bufke bufke closed this Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants