Skip to content
This repository has been archived by the owner on Oct 21, 2018. It is now read-only.

django-sis should be installable and upgradable #20

Closed
bufke opened this issue Aug 3, 2012 · 10 comments
Closed

django-sis should be installable and upgradable #20

bufke opened this issue Aug 3, 2012 · 10 comments

Comments

@bufke
Copy link
Member

bufke commented Aug 3, 2012

South integration - mostly done.
Install script - about 75% done.
Fabric update script - about 10% done.

@ghost ghost assigned calli-lilly Aug 3, 2012
@bufke
Copy link
Member Author

bufke commented Aug 5, 2012

./manage.py syncdb --migration should now work on a new installation.

We should also consider running a script to install all dependencies. I believe there is a standard people usually use for dependencies rather than just running base. For example this project has them in their own file.
https://github.com/rosarior/django-inventory/tree/master/requirements

So when I add a new dependency running fab upgrade will run this.

We also need to take more care of specifying which version should be used.

@ghost ghost assigned bufke Sep 18, 2012
@bufke
Copy link
Member Author

bufke commented Oct 1, 2012

Move to a pip requirements file
South should work
install script works

@bufke bufke closed this as completed Oct 1, 2012
@jnm
Copy link
Member

jnm commented Nov 26, 2012

Install script chokes for me on the hatchery packages. It looks like pip support for relative paths is a big mess:
pypa/pip#328

Maybe fabric can rewrite the relative paths in the requirements file into absolute paths during an install. It shouldn't be difficult to do the same in bash if fabric isn't going to handle installs.

@jnm jnm reopened this Nov 26, 2012
@bufke
Copy link
Member Author

bufke commented Nov 30, 2012

You need a newer version of pip for it work work. Ugh. As commented in that issue the file:../ to get current path does actually work.

To make it worse pip install --upgrade pip in ubuntu results in a broken path which a symlink can fix.

This problem is out of the scope of django-sis. Proposed solution is to document the issue in install.txt and say you need to have pip >= 1.2.1 and that ubuntu (and prob debian) is lame.

We can't run this on an install script as it's so nasty but we can document it must be done unless you happen in ubuntu 12.04.

pip install --upgrade pip

ln -s /usr/local/bin/pip /usr/bin/pip

What do you think?

@bufke bufke closed this as completed in 0d48ee8 Nov 30, 2012
@jnm
Copy link
Member

jnm commented Nov 30, 2012

If https://github.com/burke-software/django-sis/blob/master/install/install.sh#L15 were split into one call for everything in pypi, using the requirements file, and other calls for hatchery stuff, would that work with older pip?

@bufke
Copy link
Member Author

bufke commented Nov 30, 2012

Yea it used to be like that. It seems like the wrong way to do it. But if
it's easier go ahead and change it.

On Fri, Nov 30, 2012 at 4:01 PM, jnm notifications@github.com wrote:

If
https://github.com/burke-software/django-sis/blob/master/install/install.sh#L15were split into one call for everything in pypi, using the requirements
file, and other calls for hatchery stuff, would that work with older pip?


Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-10903793.

@ghost ghost assigned jnm Nov 30, 2012
@jnm
Copy link
Member

jnm commented Nov 30, 2012

Yeah it definitely is the wrong way :(
I'll change it for now, though.

@jnm jnm reopened this Nov 30, 2012
@bufke
Copy link
Member Author

bufke commented Jan 5, 2013

@jnm this is no longer an issue is it?

@jnm
Copy link
Member

jnm commented Jan 7, 2013

TIL bash caches executable paths. After running pip install --upgrade pip, bash still looks in the old location:

john@django-sis:~$ which pip
/usr/bin/pip
john@django-sis:~$ sudo pip install --upgrade pip
john@django-sis:~$ which pip
/usr/local/bin/pip
john@django-sis:~$ pip --version
-bash: /usr/bin/pip: No such file or directory

This can be cleared with hash -r, so we should not symlink the pip executable. It also does not affect subshells, so someone could upgrade pip and then run our install script without issue.

I have code to check pip's version that I'm about to commit.

@jnm jnm closed this as completed in e26bf97 Jan 7, 2013
@jnm
Copy link
Member

jnm commented Jun 6, 2013

I tried to do a fresh install on a clean VM and ran into some problems. These cropped up after doing the bare minimum of git clone, install.sh, and touch settings_local.py.

  • raven.contrib.django in master settings.py but not install.sh
  • responsive_dashboard in master settings.py but not install.sh
  • /opt/django-sis/media/uploads isn't in git, manage.py won't run without creating it manually
  • django-daterange-filter==0.2.0 doesn't work: 'module' object has no attribute 'Filters'
    • 0.1.1 works
  • django-grappelli==2.4.5 doesn't work: no top menu bar
    • 2.4.4 works (see screenshots)

grap 2 4 5
grap 2 4 4

@jnm jnm reopened this Jun 6, 2013
bufke added a commit that referenced this issue Jun 6, 2013
bufke added a commit that referenced this issue Jun 6, 2013
bufke added a commit that referenced this issue Jun 6, 2013
@bufke bufke closed this as completed in ed3b8cb Jun 6, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants