-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci/Add Windows pipeline #925
Conversation
The Windows CI error is related to a part of If I'm not wrong we can fix the problem using https://doc.rust-lang.org/std/env/fn.temp_dir.html |
Yeah, we should probably update the tests before merging this PR, using |
6314992
to
080d714
Compare
Saw the hack for windows. Please add the context and when this hack should be removed. Preferably we should have an issue or tondo fix the hack. The commit messages are invisible after a merge so we can't rely on them. |
Thanks @antimora for your review! Yep, I will open an issue as soon as the CI for Windows will be finished. For now I'm just investigating which issues will be arising from the execution of these CI runs |
I cannot detect where the problem is in the My attempts:
Perhaps the main problem could be in the |
Going to look at this one. |
3d87367
to
8c1b41d
Compare
This reverts commit ce30585bae433daf3009a655d95abb91fe5c0d05. Those tests have been fixed for the Windows platform.
Drop the idea to run with dx12 backend for now.
This reverts commit 096a4c1.
@nathanielsimard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙏
This reverts commit 0b2a938.
Co-Authored-By: Sylvain Benner <sylvain.benner@gmail.com>
Pull Request Template
Checklist
run-checks
script has been executed.Related Issues/PRs
Provide links to relevant issues and dependent PRs.
Changes
This PR adds
Windows
CI toburn
Testing
Describe how these changes have been tested.