New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gspread depends on google-auth>2.4.0 but only specifies google-auth>=1.12.0 #1454
Comments
Hi, I'm sorry about this issue ! I did not notice that the I will have a look and see how we can solve this. |
I check the dependencies, this going to be annoying to solve 😞
In order to solve it properly, I suggest, @alifeee let me know if you think of something better
this way anyone with a dependency on |
Sounds like a good plan to me. My personal solution was to upgrade dependencies but it was a complex web requiring a lot of updates and it would have been nice to have an option to still use gspread |
what do you think of the following change? https://github.com/burnash/gspread/compare/master..fix/api_key-auth-version Firstly, Secondly, the from gspread.auth import api_key
api_key("uijwaiofjwa") I think this keeps backwards compatibility (people can still use Then, we can think in future of increasing the minimum version in |
@alifeee thats looks great ! correct me if I'm wrong, the plan is:
if this is correct I think we should merge whatever fix we have to merge now + new features that have been waiting, then start working on version 7.0.0, what do you think ? |
sounds good. we should make a PR from https://github.com/burnash/gspread/compare/master..fix/api_key-auth-version not sure if it's that testable, will need a bit of manual testing, as version numbers are being screwed around with I am in no rush to release 7.0.0. This bugfix seems reasonable to me as |
Describe the bug
I have gspread installed against version 1.35.0 of google-auth which is within the constraints currently specified by
pyproject.toml
(google-auth>=1.12.0
) and get the following error uponimport gspread
:ModuleNotFoundError: No module named 'google.auth.api_key'
.Looks like this module only came into existence in google-auth v2.4.0 so that's the constraint that should be actually specified
To Reproduce
Steps to reproduce the behavior:
ModuleNotFoundError: No module named 'google.auth.api_key'
.The text was updated successfully, but these errors were encountered: