Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/api key auth version #1463

Merged
merged 4 commits into from May 13, 2024
Merged

Fix/api key auth version #1463

merged 4 commits into from May 13, 2024

Conversation

alifeee
Copy link
Collaborator

@alifeee alifeee commented May 10, 2024

closes #1454

changing test-requirements.txt means that the tests for api_key auth do fail.

Adding the "fix" means the tests "work" (they do not throw an exception)

@alifeee alifeee added this to the 6.1.1 milestone May 10, 2024
@alifeee alifeee requested a review from lavigne958 May 10, 2024 12:43
Copy link
Collaborator

@lavigne958 lavigne958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix !

I noticed our test suite uses a different version for the google auth lib.

I coul add a new test in the CI that checks the version of the dependencies in the file pyproject.toml and in the test-requirements.txt file and ensures they are the same ! otherwise we forgot to update one or another.

@alifeee
Copy link
Collaborator Author

alifeee commented May 13, 2024

I coul add a new test in the CI that checks the version of the dependencies in the file pyproject.toml and in the test-requirements.txt file and ensures they are the same ! otherwise we forgot to update one or another.

I don't think this is necessary. After this PR, they will be the same.

If we update the version in pyproject.toml, it will be presumably because we had to (to fix something broken). When we fix it, the tests should break too (as they will be using an older version of auth libraries).

I will merge this 👍

@alifeee alifeee merged commit 7dd34df into master May 13, 2024
10 checks passed
@alifeee alifeee deleted the fix/api_key-auth-version branch May 13, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gspread depends on google-auth>2.4.0 but only specifies google-auth>=1.12.0
2 participants