Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/get all record duplicated columns #1021

Merged
merged 3 commits into from
Apr 12, 2022

Commits on Apr 6, 2022

  1. Add expected headers argument

    Add a new argument to `get_all_records` to provide the list of expected
    headers.
    
    The given expected headers must:
    - be unique
    - be part of the complete headers list
    - must not contain extra headers
    
    This will provide a way for users to use this method and still
    have *some* duplicated headers that are not relevant to pull.
    
    This will ensure the columns that matters have unique headers.
    
    Closes #1007
    lavigne958 committed Apr 6, 2022
    2 Configuration menu
    Copy the full SHA
    11b432a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    87c7950 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2022

  1. Improve test coverage for get_all_records

    Improved test coverage, make sure the logic is and remains.
    Add note to users to expect all headers to be returned even if only a
    subset is provided by `expected_headers`.
    Updated test cassette on the way.
    Clean old comment in tests when preparing sheet data.
    lavigne958 committed Apr 10, 2022
    Configuration menu
    Copy the full SHA
    691e25c View commit details
    Browse the repository at this point in the history