Bugfix/numericese all #1119
Merged
Bugfix/numericese all #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user passes `None` as a list to ignore to the function `numericise_all` it crashes because it tries to iterate over the list. cover that case be setting the ignored list to an empty list if not set. Later solution will be to add typing to this project. closes #1118
this is to prevent error with older version that pulls importlib-metadata==5.0.0 and does not work. This new version sets a upper bound on importlib-metadata version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent crash when passing
Nonetonumericise_allWhen a user passes
Noneas a list to ignore to the functionnumericise_allit crashes because it tries to iterate over the list.cover that case be setting the ignored list to an empty list if not set.
Later solution will be to add typing to this project.
closes #1118