#1104: added a delete by worksheet id method #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for your contribution. I need to check what is this new vulnerability and how we can solve it. Until then unfortunately we can't merge your PR 😔 |
|
I understand
…On Sat, Nov 19, 2022 at 4:31 PM Alexandre Lavigne ***@***.***> wrote:
Hi, thank you for your contribution.
I need to check what is this new vulnerability and how we can solve it.
Until then unfortunately we can't merge your PR 😔
—
Reply to this email directly, view it on GitHub
<#1148 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI2VVZTXHBMZRWMPHWXU2A3WJC3BPANCNFSM6AAAAAASEL5LKE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hello the CI has been fixed, you should now be able to merge your PR, could you please rebase it onto the master branch ? |
lavigne958
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1104
Added a delete by Worksheet Id method in the Spreadsheet Class