-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLEANUP: cleanup tox.ini, and ignore ./env #1200
Conversation
Thanks that's great ! 😃 I noticed it too. I thought about the following changes: using the command I mostly faced issues when it tries to lint my dev files that are not formatted at all. We can mix your proposal with mine in this PR. |
And changing file exclusions to file inclusions? That sounds smart. |
I let you do the changes in your PR? Remove the exclude list in lint/format. Then instead of Hope this works but I'm not sure if tow runs the commands in a shell or not. |
In fact I was wrong we don't have access to a shell we should keep it like this for now (in terms of exclude/include). We may introduce exclude list to |
Ah, ok. Sounds good.
In theory, you should be able to make changes in my repository, since you are a maintainer. However, I will make this small change. |
I think that black is smart anyway, and does not re-compute files it has already done once. Although perhaps that would be an issue in a cache-less CI job
commands already include a nice set of defaults. I'd rather not override them. --extend-include allows you to add more to the list see "flake8 --help", "black --help", or "isort --help" for more
I believe this can be merged 👍 |
tox was taking a long time to run. This was because it was checking all the files in my python virtual environment, in
./env
.The .gitignore suggests that a python virtual environment should be called
env
, which is what mine is.I have added a skip/ignore to the lint/format commands, so they no longer look in
./env
.This also has the benefit that they are much faster to run (around 8 secs to lint, 5 secs to format).