Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Drive API access on Spreadsheet init (FIX - VERSION 5.11.1) #1291

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

alifeee
Copy link
Collaborator

@alifeee alifeee commented Sep 6, 2023

Adding this line to Spreadsheet.__init__()

drive_metadata = self.client.get_file_drive_metadata(self._properties["id"])
self._properties.update(drive_metadata)

has caused many issues (#1286, #1290) due to gspread being used with an API key/access token/etc which does not have access to the Drive API.

I propose that we remove this line (effectively reverting #1255) and release a new patch -> v5.11.1.

I think what #1255 fixes (removal of a single API call on two rarely used(?) spreadsheet properties) is not worth the implications that requiring the Drive API by default brings.

I would like to make this change asap but will wait for your approval @lavigne958.

@alifeee alifeee self-assigned this Sep 6, 2023
Copy link
Collaborator

@lavigne958 lavigne958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this brings too much problems to the users.

That's a good call.

@lavigne958
Copy link
Collaborator

You make the new release too ?
We should probably add some mentions in the release note ? 🤔

@alifeee
Copy link
Collaborator Author

alifeee commented Sep 6, 2023

I will make the new release.

Not sure what you want in the release notes, but you can edit it after I make it :). A bit like the note I made in the 5.11.0 release notes?

@alifeee alifeee merged commit cbd612b into master Sep 6, 2023
12 checks passed
@alifeee alifeee deleted the fix/remove-drive-api-call branch September 6, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants