allows users to silence deprecation warnings #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anyone can silence all the deprecation warnings using the env variable GSPREAD_SILENCE_WARNINGS=1 closes #1323 Signed-off-by: Alexandre Lavigne <lavigne958@gmail.com>
alifeee
requested changes
Oct 19, 2023
There was a problem hiding this comment.
Looks good to me. I have suggested some minor changes.
If it is simple to add a test for this, then we should. Perhaps using pytest's with pytest.deprecated_call or with pytest.warns
Signed-off-by: Alexandre Lavigne <lavigne958@gmail.com>
|
I updated based on the review |
alifeee
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anyone can silence all the deprecation warnings using the env variable
GSPREAD_SILENCE_WARNINGS=1
closes #1323
Signed-off-by: Alexandre Lavigne lavigne958@gmail.com