Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning/update swapped args #1336

Merged
merged 3 commits into from Nov 1, 2023

Conversation

alifeee
Copy link
Collaborator

@alifeee alifeee commented Oct 28, 2023

closes #1325

If they "seem" swapped, I swap them back and emit a warning. We may instead want to just raise a ValueError. Up to you @lavigne958

@alifeee alifeee added this to the 6.0.0 milestone Oct 28, 2023
@alifeee alifeee self-assigned this Oct 28, 2023
Copy link
Collaborator

@lavigne958 lavigne958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine to me, this will help people use gspread even though their code is not correct ans possibly a lot of users won't change their code as may no understand what is the difference between argument list and key-value arguments too.

@alifeee alifeee merged commit 6602fbd into feature/release_6_0_0 Nov 1, 2023
10 checks passed
@alifeee alifeee deleted the warning/update-swapped-args branch November 1, 2023 17:19
@alifeee alifeee mentioned this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants