Many fixes for get_records

[alifeee]

closes #590, #629, #1354, #1355

firstly, a test simplification

This is done for a few tests

...
- cell_list = self.sheet.range("A1:D4")
- for cell, value in zip(cell_list, itertools.chain(*rows)):
-   cell.value = value
- self.sheet.update_cells(cell_list
+ self.sheet.update("A1:D4", rows)
...

combine test_get_all_records_duplicate_keys and test_get_all_records_expected_headers

add test_get_all_records_with_blank_final_headers

Regression test for #1354

tests get_records with some blank final headers, i.e.,

"header 1"	"header 2"	""	""

It should throw an error, but work fine with expected_headers set

add test_get_all_records_with_keys_blank

Similar to above but with the entire keys row blank

add test_get_records_with_all_values_blank

This is the beefy one. Regression test for #590, #629, #1355

Given the sheet

"a"	"b"	"c"
""	""	""
""	""	""

What should get_records return?

• [] ?
• [{"a": "", "b": "", "c": ""}, {"a": "", "b": "", "c": ""}] ?

This is a hard question. My answer uses the kwarg last_index. If this is asked for (i.e., if a user asks for "five rows"), then I believe get_records should return a list of length asked for (i.e., length 5). If it is not asked for (i.e., if a user asks for "entire sheet"), then I believe get_records should return an empty list (not further because we "don't know" how long a spreadsheet is). This logic is explained by:

I ask for get_records(first_index=2, last_index=4)

I want [{...}, {...}, {...}]

I ask for get_records()

I want []

I ask for get_records(first_index=1)

I want []

I ask for get_records(last_index=4)

I want [{...}, {...}, {...}]

Thus, this is the logic I included in test_get_records_with_all_values_blank

[lavigne958]

closes #590, #629, #1354, #1355

firstly, a test simplification

This is done for a few tests

...
- cell_list = self.sheet.range("A1:D4")
- for cell, value in zip(cell_list, itertools.chain(*rows)):
-   cell.value = value
- self.sheet.update_cells(cell_list
+ self.sheet.update("A1:D4", rows)
...

combine test_get_all_records_duplicate_keys and test_get_all_records_expected_headers

add test_get_all_records_with_blank_final_headers

Regression test for #1354

tests get_records with some blank final headers, i.e.,

"header 1" "header 2" "" ""
It should throw an error, but work fine with expected_headers set

add test_get_all_records_with_keys_blank

Similar to above but with the entire keys row blank

add test_get_records_with_all_values_blank

This is the beefy one. Regression test for #590, #629, #1355

Given the sheet

"a" "b" "c"
"" "" ""
"" "" ""
What should get_records return?

• [] ?
• [{"a": "", "b": "", "c": ""}, {"a": "", "b": "", "c": ""}] ?

To le we should return an empty list.
There is not data.

This is a hard question. My answer uses the kwarg last_index. If this is asked for (i.e., if a user asks for "five rows"), then I believe get_records should return a list of length asked for (i.e., length 5). If it is not asked for (i.e., if a user asks for "entire sheet"), then I believe get_records should return an empty list (not further because we "don't know" how long a spreadsheet is). This logic is explained by:

I ask for get_records(first_index=2, last_index=4)

I want [{...}, {...}, {...}]

I ask for get_records()

I want []

I ask for get_records(first_index=1)

I want []

I ask for get_records(last_index=4)

I want [{...}, {...}, {...}]

Thus, this is the logic I included in test_get_records_with_all_values_blank

Make sense if the user requests a range limit then get empty values with the requested size. Otherwise juste empty list.

I will take a look ASAP. By the end of the weekend it should be done.

Great job and thank you for taking it si fast.

[alifeee]

I will take a look ASAP. By the end of the weekend it should be done.

Super :) let me know if you think we should change anything

[lavigne958]

Looks good to me 👍