Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change worksheet.update migration guide #1362

Merged
merged 1 commit into from Dec 4, 2023
Merged

change worksheet.update migration guide #1362

merged 1 commit into from Dec 4, 2023

Conversation

alifeee
Copy link
Collaborator

@alifeee alifeee commented Dec 4, 2023

see discussion in #1360

@alifeee alifeee self-assigned this Dec 4, 2023
@alifeee alifeee added this to the 5.12.2 milestone Dec 4, 2023
@alifeee alifeee mentioned this pull request Dec 4, 2023
Closed
@NickCrews
Copy link
Contributor

much better, and great idea adding the # unchanged version as well. Thank you!

@alifeee alifeee mentioned this pull request Dec 4, 2023
Closed
lavigne958
lavigne958 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@lavigne958 lavigne958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great change, this is clearer.

@lavigne958 lavigne958 mentioned this pull request Dec 4, 2023
Closed
@alifeee alifeee merged commit 586e9b1 into master Dec 4, 2023
12 checks passed
@alifeee alifeee deleted the fix/update-migration-guide branch December 4, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavigne958 lavigne958 lavigne958 approved these changes

Assignees

@alifeee alifeee

Labels
Improvement
Projects
None yet
Milestone
5.12.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alifeee @NickCrews @lavigne958