check oauth creds type using isinstance

[alifeee]

closes #1390

Credentials object is renamed OAuthCredentials in v6.0.0, and is no longer Credentials type, so the type-check for "already logged in" was failing. See #1390 (comment) for more context.

It is worth noting that types were being checked with type(). This it not reccomended as per pylint.

If we had been using isinstance, this bug would not appear, as

if not type(creds) is Credentials: did not work with OAuthCredentials
if not isinstance(creds, Credentials): would have worked with OAuthCredentials as it is a subclass of Credentials

• I do not know enough about oauth to add an adequate test so that this problem does not happen again
• I do not know enough about oauth to know if this renaming of Credentials -> OAuthCredentials could have other problems in auth.py or elsewhere

Thus, the result of this change is only tested manually, by me, on my computer.... :/

[lavigne958]

very good catch ! I believe what we need is betwenn what you found and what was originally here:

• using isinstance instead of type
• using the generic base class Credentials

[lavigne958]

closes #1390

Credentials object is renamed OAuthCredentials in v6.0.0, and is no longer Credentials type, so the type-check for "already logged in" was failing. See #1390 (comment) for more context.

It is worth noting that types were being checked with type(). This it not reccomended as per pylint.

If we had been using isinstance, this bug would not appear, as

if not type(creds) is Credentials: did not work with OAuthCredentials if not isinstance(creds, Credentials): would have worked with OAuthCredentials as it is a subclass of Credentials

• I do not know enough about oauth to add an adequate test so that this problem does not happen again

Unfortunately we can't add tests on oauth because it requires your to open a browser to allow the access.
There are possible way to make it work... but it would take us a considerable amount of time that can be used elsewhere I suppose. We must remind ourselves to manually test it from time to time or when changing anything around it !

• I do not know enough about oauth to know if this renaming of Credentials -> OAuthCredentials could have other problems in auth.py or elsewhere

as I recommended we should keep comparing to the base class so this won't be a problem.

Thus, the result of this change is only tested manually, by me, on my computer.... :/