Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type hints at find method in worksheet.py #1407

Merged
merged 1 commit into from Feb 3, 2024
Merged

Fix type hints at find method in worksheet.py #1407

merged 1 commit into from Feb 3, 2024

Conversation

deftfitf
Copy link
Contributor

@deftfitf deftfitf commented Feb 3, 2024

Hi, I changed the type hints for the in_row and in_column arguments of the find method in worksheet.py from Optional[bool] to Optional[int].

Could you check this later?

lavigne958
lavigne958 approved these changes Feb 3, 2024
View reviewed changes
Copy link
Collaborator

@lavigne958 lavigne958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution 🙏
That's a good catch

@lavigne958 lavigne958 merged commit 01ed04c into burnash:master Feb 3, 2024
5 checks passed
@deftfitf deftfitf deleted the fix/find-type-argument branch February 3, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavigne958 lavigne958 lavigne958 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deftfitf @lavigne958