Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update migration guide #1409

Merged
merged 1 commit into from
Feb 6, 2024
Merged

update migration guide #1409

merged 1 commit into from
Feb 6, 2024

Conversation

alifeee
Copy link
Collaborator

@alifeee alifeee commented Feb 6, 2024

closes #1408

  • add Worksheet.__init__ change
  • hide "rarer" changes under <details> so users are not overwhelmed by changes, and can get to "more examples" easier

guide now looks like (see on branch)

image

I have hidden some of the suggested migration changes, as I think they are less important. I think it is more important for people reading the README to get to the More Examples section, especially if they are new to the library.

Thanks. Let me know if you think we should change this at all. Or just push to the branch :)

After this we can release 6.0.1?

add `Worksheet.__init__` change
hide "rarer" changes under <details> so users are not overwhelmed by changes,
and can get to "more examples" easier
@alifeee alifeee added the Docs label Feb 6, 2024
@alifeee alifeee added this to the 6.0.1 milestone Feb 6, 2024
@alifeee alifeee self-assigned this Feb 6, 2024
Copy link
Collaborator

@lavigne958 lavigne958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a very good change and it provides a better user experience. 👌

@alifeee alifeee merged commit 591a93d into master Feb 6, 2024
10 checks passed
@alifeee alifeee deleted the update/readme-migration-guide branch February 6, 2024 12:53
@lavigne958
Copy link
Collaborator

Agreed we can now release 6.0.1 I'll do it in a minute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new Worksheet init arguments to migration guide
2 participants