Feature/add header validation get all records #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before each test, the current worksheet is cleared to make sure the test start with no values from previous test. This was recorded in the same test cassette and the API call to clear the sheet is the same every time. This leads to pyvcr not making the actuall HTTP request and not clearing the worksheet because it uses the response from the cassette. Moved the record of the HTTP requests to clear the worksheet with the test itself, this makes sure it is made for each test during recording. Closes #983
The header row used as kesy for the created dict must contain no duplcated values. Check that each value is unique. Closes #973
filip-31
reviewed
Jan 24, 2022
burnash
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st commit:
Fix issue with tests cassettes.
2nd commit:
Add header validation for method
get_all_records.If duplicate headers exists raise exception.
Again, like any changes on test cassettes, skip the first commit to prevent your diff to show 1000s of lines.
Or use github to only show you the diff on
.pyfiles.