Skip to content
This repository has been archived by the owner on Dec 17, 2019. It is now read-only.

burning-duck discussion #5

Open
pbit opened this issue Apr 13, 2017 · 16 comments
Open

burning-duck discussion #5

pbit opened this issue Apr 13, 2017 · 16 comments

Comments

@pbit
Copy link
Member

pbit commented Apr 13, 2017

Remove all modules we dont need

  • Tours
  • Destinations
  • Demo content
@pbit
Copy link
Member Author

pbit commented Apr 13, 2017

Do we need a custom bundle for this?

@janroesler
Copy link
Member

janroesler commented Apr 13, 2017

I think we should use the empty-webapp + CE bundle you made the last day..
We also can clean up the light-module to get one main page and one content page.
No more is needed at this time.

janroesler added a commit that referenced this issue Apr 13, 2017
create new areas and templates
use mtk / mte components
@janroesler
Copy link
Member

Ok we need a clean .war file.
@pbit where is the link for tomcat bundle :)

@pbit
Copy link
Member Author

pbit commented Apr 14, 2017

Workin on it, push it to GH once its working.

@janroesler
Copy link
Member

Ok, i have test yesterday the author and public configuration for the magnolia basic cms. Have move the war on the burning-duck server. But don't get it running :(

@janroesler
Copy link
Member

Or lets say, Magnolia is running but don't load the right configuration 🗡
I have something wrong in the web.xml , i think.

@pbit
Copy link
Member Author

pbit commented Apr 15, 2017

Yeah we only had this config in local development.

But there is an entry in web.xml which should work (tm):
image

So it should be work if the context parameter is set:

In context.xml?

<Context>
  ...
  <Parameter name="magnoliaMode" value="public"
         override="false"/>
  ...
</Context>

@pbit
Copy link
Member Author

pbit commented Apr 15, 2017

Currently wrestling with maven...

  • BAM breaks nearly everything -> remove it
  • Magnolia enforces Magnolia license in all source files -> remove it

so there is not much left we can use ;)

@janroesler
Copy link
Member

janroesler commented Apr 20, 2017

I have add the component for the page teaser.
Now it works like expected.
Need some improvements like:

  • add field for substring length (?substring (0, ${content.val})
  • add field for poste date
  • add field or select for author

I think it would be nice when we have the component #4 for the version badge.
We can include the dialog field and the template in the teaser component 👍

And i add a card layout, but i don't know, don't feel right. We need a MEG 😄

@janroesler
Copy link
Member

So add issues #9 and #10 for refactoring.

@janroesler
Copy link
Member

janroesler commented Apr 26, 2017

We need the md component :D
If we have the component, is the "text and image" component still needed? @pbit

@pbit
Copy link
Member Author

pbit commented Apr 27, 2017

Yeah, CMS bundle is on the way hust cleaning up a few things.
@janroesler I would keep the text and image, may be easier to add small content everywhere.

@janroesler janroesler changed the title Clean installation burning-duck discussion Apr 27, 2017
@janroesler
Copy link
Member

Ok, we have the bundle with markdownfn. The refactoring of this light module is almost done.
Is in the bundle a ready to use component for markdownfn? @pbit
Or should we create a new light module for this component?

@janroesler
Copy link
Member

Have create the project https://github.com/orgs/burning-duck/projects/1 to add ideas for anything.
So we have nodes for any idea and don't lost something.

@janroesler
Copy link
Member

Ok i have add a md component, but i don't get it running.
That is your part @pbit 📄

@pbit
Copy link
Member Author

pbit commented Apr 28, 2017

@janroesler but it worked on my machine ...

Basic syntax in freemarker:

[#if content.md?has_content]
${markdownfn.renderToHtml(content, "md")}
[/#if]

If the markdown comes from a JCR-Node or ContentMap we are not able to render the returned value.
There is some HtmlEscaping involved which breaks the renderer.
For more info see Javadocs in https://github.com/burning-duck/burning-duck-cms-bundle/blob/master/src/main/java/com/github/burningduck/cms/markdown/MarkdownTemplatingFunctions.java

In theory this opens a door which was closed by HtmlEscaping, as the original Node is unwraped, but if you know what youre doing there should be no problems.

The installer should register the functions:

image

The highlighting is not done on the server, I just dropped in http://prismjs.com/ ....

janroesler pushed a commit that referenced this issue Apr 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants