Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create /etc/sql_exporter in postinstall #236

Merged
merged 2 commits into from May 13, 2023

Conversation

dupondje
Copy link
Contributor

This fixes install error:
cp: cannot create regular file '/etc/sql_exporter/sql_exporter.yml': No such file or directory

@burningalchemist
Copy link
Owner

Hi @dupondje, great catch, thanks a lot! 👍

@burningalchemist
Copy link
Owner

@dupondje do you mind moving the mkdir command above the line 25, though:

mkdir -p $CONF_PATH <-- here
cp /usr/share/sql_exporter/sql_exporter.yml $CONF_FILE

In this case we don't hardcode names and the cp command works well too.

Copy link
Owner

@burningalchemist burningalchemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes suggested in the main comment.

This fixes install error:
cp: cannot create regular file '/etc/sql_exporter/sql_exporter.yml': No such file or directory

Also fix indent
Copy link
Owner

@burningalchemist burningalchemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍🚀

@burningalchemist burningalchemist merged commit a8cf79d into burningalchemist:master May 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants