Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): sync go versions between promu crossbuild and docker images #494

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

burningalchemist
Copy link
Owner

To have consistent builds we want to make sure Go version is the same for all the builds. It wasn't a problem before v1.22, but it seems to be a good opportunity to improve consistency these days.

Notable changes

  • Update Dockerfile.multi-arch so it takes a build argument (with latest being a default value) that we can pick from .promu.yml;
  • Add a step to GitHub actions to obtain the version from the config file, and store it in the step output key.

Additional notes

  • In the future we might want to drop building binaries again and reuse ones built by promu crossbuild. So the Dockerfile will be changed, the builds also should become faster.

@burningalchemist burningalchemist merged commit 0e98a1c into master Apr 7, 2024
4 checks passed
@burningalchemist burningalchemist deleted the dockerfile/goversion branch April 7, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant