Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: indentation of extra volume mounts in deployment.yaml #496

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

Fapiko
Copy link
Contributor

@Fapiko Fapiko commented Apr 11, 2024

This was causing an issue where it couldn't properly decode extra volume mounts due to the indentation being out of alignment:

Error: YAML parse error on sql-exporter/templates/deployment.yaml: error converting YAML to JSON: yaml: line 48: did not find expected key
helm.go:84: [debug] error converting YAML to JSON: yaml: line 48: did not find expected key

@burningalchemist
Copy link
Owner

Hey @Fapiko, thanks for finding the issue and contributing a fix. I'll test it shortly, and create a new release.

@burningalchemist
Copy link
Owner

@Fapiko could you please bump up a chart release version here to 0.4.5;

And also run make gen_docs command from the helm directory.

@Fapiko
Copy link
Contributor Author

Fapiko commented Apr 11, 2024

@burningalchemist Done

@burningalchemist burningalchemist merged commit c84384f into burningalchemist:master Apr 11, 2024
4 checks passed
@burningalchemist
Copy link
Owner

Released as 0.4.5 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants