-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): Sidecar and Service Account Update #509
feat(helm): Sidecar and Service Account Update #509
Conversation
…ntity and / or extra containers
link #507 to this PR |
Bumped chart version a little so the lint won't fail so hard. |
There are some small linting issues for values.yaml:
|
My mistake - every pipeline is a little different. Will push a fix now. |
Yeah, no rush. The linter is quite strict, just to make sure the helm install/upgrade tests are stable. I guess you need to make sure the last line has a new line control character, but is not an empty line itself. |
As many a famous developer has said "it passes on my machine now, give it a shot" |
I should get a first MR badge from this! I am so sorry for the trouble - my conditional wasn't complete I should've caught that. |
@jluckett-panw no worries at all, take your time. 😃👍 |
Last time today - I have manually run through your ci process on a GKE cluster and upgrades go off without a hitch. I will not bother you again until Monday if this one doesn't work. TIA! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jluckett-panw LGTM! 🚀 Thanks a lot for your contribution! 👏
@jluckett-panw just a heads up - I've readjusted the logic for serviceAccount object creation/referencing here. Your changes are already released as of v0.4.6. v0.5.0 has a slightly different mechanism, so it's a breaking change. Please be aware in case of upgrade. 👍 |
Enable extra containers and service account customization to facilitate running a sql auth proxy as a sidecar. The service account customization was necessary to enable alternative authentication methods such as workload identity.
Please squash when merging.
resolves #507