-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
open github.com/nats-io/nats.go: no such file or directory. exit status 2 #539
Comments
Where did you run that command from? A clone of the repository? At what version? |
just import a big library: github.com/ChaunceyShannon/golanglibs
|
mvdan
added a commit
to mvdan/garble-fork
that referenced
this issue
May 17, 2022
When splitFlagsFromFiles saw "-p foo/bar.go", it thought that was the first Go file, when in fact it's not. We didn't notice because such import paths are pretty rare, but they do exist, like github.com/nats-io/nats.go. Before the fix, the added test case fails as expected: > garble build -tags buildtag [stderr] # test/main/goextension.go open test/main/goextension.go: no such file or directory We could go through the trouble of teaching splitFlagsFromFiles about all of the flags understood by the compiler and linker, but that feels like far more code than the small alternative we went with. And I'm pretty sure the alternative will work pretty reliably for now. Fixes burrowers#539.
Thanks for the details! I believe the fix is #540, if you want to give it a try. |
lu4p
pushed a commit
that referenced
this issue
May 18, 2022
When splitFlagsFromFiles saw "-p foo/bar.go", it thought that was the first Go file, when in fact it's not. We didn't notice because such import paths are pretty rare, but they do exist, like github.com/nats-io/nats.go. Before the fix, the added test case fails as expected: > garble build -tags buildtag [stderr] # test/main/goextension.go open test/main/goextension.go: no such file or directory We could go through the trouble of teaching splitFlagsFromFiles about all of the flags understood by the compiler and linker, but that feels like far more code than the small alternative we went with. And I'm pretty sure the alternative will work pretty reliably for now. Fixes #539.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of Garble and Go are you using?
What environment are you running Garble on?
go env
OutputWhat did you do?
What did you expect to see?
Success build
What did you see instead?
The text was updated successfully, but these errors were encountered: