Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dependency versions #117

Merged
merged 1 commit into from
Aug 29, 2020
Merged

update dependency versions #117

merged 1 commit into from
Aug 29, 2020

Conversation

mvdan
Copy link
Member

@mvdan mvdan commented Aug 28, 2020

Most notably, x/mod now includes the GOPRIVATE pattern-matching API we
were copying before, so we can use it directly.

@mvdan
Copy link
Member Author

mvdan commented Aug 28, 2020

The tip failure is a known issue with testscript. We'll fix the library over the weekend, so we should probably wait for that before merging this.

@mvdan
update dependency versions
e1b827f 
Most notably, x/mod now includes the GOPRIVATE pattern-matching API we
were copying before, so we can use it directly.

Also bump the Go version requirement to 1.15, in preparation for the
import path obfuscation PR, and don't let the gotip job fail the entire
workflow.
@mvdan
Copy link
Member Author

mvdan commented Aug 29, 2020

Hm, I wonder if there's a point in keeping gotip around if we don't care about its output, and it's going to break somewhat regularly by design.

@capnspacehook
Copy link
Member

I still think it is valuable for planning purposes; lets us know that maybe a change/addition that works now might not work in the next release. For instance, object file format changing slightly for Go 1.16.

@mvdan
Copy link
Member Author

mvdan commented Aug 29, 2020

I agree, actually. I thought continue-on-error would mean that gotip failing would still mean a green tick, but it just means that the other jobs aren't cancelled immediately. So we get the result we want, it's just that the UI is a bit confusing. actions/runner#2347 tracks a proper "allow failure" feature.

capnspacehook
capnspacehook approved these changes Aug 29, 2020
View reviewed changes
Copy link
Member

@capnspacehook capnspacehook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvdan mvdan merged commit b250b64 into master Aug 29, 2020
@mvdan mvdan deleted the mod-updates branch August 29, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capnspacehook capnspacehook capnspacehook approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvdan @capnspacehook