make "garble version" include VCS information #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On second thought, this only builds on Go 1.18, and we're going to drop Go 1.17 support right after the upcoming release, so I can't be bothered to do the build tag dance. Let's sit on this until after the release. |
mvdan
commented
Mar 21, 2022
|
The release is done, but I'll wait a couple of days before dropping support for Go 1.17, in case any major bugs or regressions are filed for v0.6.0. |
|
Rebased and ready for review, now that we dropped Go 1.17. |
When someone builds garble from a git clone, the resulting binary used to not contain any information: $ garble version (devel) Since Go 1.18, VCS information is stamped by default into binaries. We now print it, alongside any other available build settings: $ garble version mvdan.cc/garble (devel) Build settings: -compiler gc CGO_ENABLED 1 GOARCH amd64 GOOS linux GOAMD64 v3 vcs git vcs.revision 91ea246 vcs.time 2022-03-18T13:45:11Z vcs.modified true Note that it's still possible for a garble build to contain no useful version information, such as when built via "go build -buildvcs=false". However, if a user opts into omitting the information, it's on them to figure out what version of garble they actually built. While here, bump test-gotip. Fixes burrowers#491.
lu4p
approved these changes
Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)
Fixes #491.