feat(send): add support for hex messages to send burst form #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #698 +/- ##
========================================
Coverage 93.97% 93.97%
========================================
Files 115 115
Lines 1675 1675
Branches 156 156
========================================
Hits 1574 1574
Misses 101 101Continue to review full report at Codecov.
|
ohager
approved these changes
Sep 8, 2019
| import {ApiService} from '../../api.service'; | ||
| import {AccountService} from 'app/setup/account/account.service'; | ||
| import {convertAddressToNumericId} from '@burstjs/util/out'; |
| attachment = new AttachmentEncryptedMessage(encryptedMessage); | ||
| } else if (message) { | ||
| attachment = new AttachmentMessage({message, messageIsText: true}); | ||
| attachment = new AttachmentMessage({message, messageIsText: messageIsText}); |
There was a problem hiding this comment.
No need to assign messageIsText...can be shortened
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a checkbox under
advancedfor 'Message is Text?'. When checked (default checked), the message is treated as text. When unchecked, the message is parsed as hex.Closes #696. @jjos2372 💋