Build fixes #15
Build fixes #15
Conversation
| driverMajorVersion = Integer.parseInt(matcher.group(1)); | ||
| driverMinorVersion = Integer.parseInt(matcher.group(2)); | ||
| } else { | ||
| throw new RuntimeException("Could not parse driver version: " + driverVersion); |
There was a problem hiding this comment.
What happens if you throw a runtime exception from a static block?
There was a problem hiding this comment.
You will get the error when you try to check the version:
Exception in thread "main" java.lang.ExceptionInInitializerError
at io.burt.athena.AthenaDatabaseMetaData.getDriverVersion(AthenaDatabaseMetaData.java:42)
at io.burt.athena.Test.main(Test.java:16)
Caused by: java.lang.RuntimeException: Could not parse driver version: 0.3a.0-SNAPSHOT
at io.burt.athena.AthenaDriverInfo.<clinit>(AthenaDriverInfo.java:27)
... 2 more
The solution I have implemented here is based on the top answer to this StackOverflow post: https://stackoverflow.com/questions/3697449/retrieve-version-from-maven-pom-xml-in-code |
pom.xml
Outdated
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| <groupId>io.burt</groupId> | |||
| <artifactId>athena-jdbc</artifactId> | |||
| <version>0.2.0</version> | |||
| <version>0.3.0-SNAPSHOT</version> | |||
There was a problem hiding this comment.
Perhaps you need to modify this to make sure the changes work, but in general, only change project versions on master or in release-only branches. The reason is that the current version may be 0.4 or 9.1 by the time this gets merged.
There was a problem hiding this comment.
Good point, reverted.
| import java.util.regex.Matcher; | ||
| import java.util.regex.Pattern; | ||
|
|
||
| public class AthenaDriverInfo { |
There was a problem hiding this comment.
This could be a package private class, there isn't any need to expose it unless we have to. Someone might start using it.
stenlarsson
force-pushed
the
build-fixes
branch
from
026dd80
to
d4b0fc7
Compare
The version of the driver was hard coded in AthenaDatabaseMetaData which causes the tests to fail when bumping the version during the release process. To fix this we create a properties file, and tell Maven to write the project version to this file. Then we load and parse the version number from this properties file. There are also another properties file `META-INF/maven/io.burt/athena-jdbc/pom.properties` added automatically to the jar file, but this file cannot be used in the unit tests.
For some reason the "release" profile is always active, which causes it to try to sign the jar file even when doing a simple "mvn install". Not sure what activates it, but renaming it seems to prevent it from happening.
When building the jar in Java 8 it fails because the -html5 flag is not supported.
stenlarsson
force-pushed
the
build-fixes
branch
from
d4b0fc7
to
44ffbb1
Compare
This fixes a number of issues with the build system. I actually implemented these back in February, but didn't get around to creating a PR until now.
Automatically set driver version from artifact version
The version of the driver was hard coded in
AthenaDatabaseMetaDatawhich causes the tests to fail when bumping the version during the release process. To fix this we create a properties file, and tell Maven to write the project version to this file. Then we load and parse the version number from this properties file.I have tried various other solutions that involve replacing the version in the code directly, but none of them works when running the unit tests.
Rename release profile
For some reason the "release" profile is always active, which causes it to try to sign the jar file even when doing a simple
mvn install. Not sure what activates it, but renaming it seems to prevent it from happening.Only specify HTML5 javadoc in version 1.9 or higher
When building the jar in Java 8 it fails because the
-html5flag is not supported.Move to next snapshot releaseThis should have been done after the last release.Should not be done as part of this PR.