Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize StringBuilder based loops #50

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import java.util.List;
import java.util.ArrayList;
import java.util.Iterator;

import io.burt.jmespath.Adapter;
import io.burt.jmespath.Expression;
Expand All @@ -21,7 +20,7 @@ public T search(T input) {
if (runtime.typeOf(input) == JmesPathType.NULL) {
return input;
} else {
List<T> array = new ArrayList<>();
List<T> array = new ArrayList<>(entries.size());
for (Expression<T> entry : entries) {
array.add(entry.search(input));
}
Expand All @@ -31,17 +30,16 @@ public T search(T input) {

@Override
protected String internalToString() {
if (entries.isEmpty()) {
return "[]";
}

StringBuilder str = new StringBuilder("[");
Iterator<Expression<T>> entryIterator = entries.iterator();
while (entryIterator.hasNext()) {
Expression<T> entry = entryIterator.next();
str.append(entry);
if (entryIterator.hasNext()) {
str.append(", ");
}
for (Expression<T> entry: entries) {
slandelle marked this conversation as resolved.
Show resolved Hide resolved
str.append(entry).append(", ");
}
str.append(']');
return str.toString();
str.setLength(str.length() - 2);
return str.append(']').toString();
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import java.util.Map;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Iterator;

import io.burt.jmespath.Adapter;
import io.burt.jmespath.Expression;
Expand Down Expand Up @@ -70,17 +69,16 @@ public T search(T input) {

@Override
protected String internalToString() {
if (entries.isEmpty()) {
return "{}";
}

StringBuilder str = new StringBuilder("{");
Iterator<Entry<T>> entryIterator = entries.iterator();
while (entryIterator.hasNext()) {
Entry<T> entry = entryIterator.next();
str.append(entry.key()).append('=').append(entry.value());
if (entryIterator.hasNext()) {
str.append(", ");
}
for (Entry<T> entry : entries) {
str.append(entry.key()).append('=').append(entry.value()).append(", ");
}
str.append('}');
return str.toString();
str.setLength(str.length() - 2);
return str.append('}').toString();
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import java.util.List;
import java.util.ArrayList;
import java.util.Iterator;

import io.burt.jmespath.Adapter;
import io.burt.jmespath.Expression;
Expand Down Expand Up @@ -39,16 +38,13 @@ protected String internalToString() {
str.append(implementation.name());
}
str.append(", [");
Iterator<Expression<T>> argIterator = args.iterator();
while (argIterator.hasNext()) {
Expression<T> arg = argIterator.next();
str.append(arg);
if (argIterator.hasNext()) {
str.append(", ");
}
for (Expression<T> arg : args) {
str.append(arg).append(", ");
}
if (!args.isEmpty()) {
str.setLength(str.length() - 2);
}
str.append(']');
return str.toString();
return str.append(']').toString();
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public String toString() {
StringBuilder str = new StringBuilder();
String name = getClass().getName();
str.append(name.substring(name.lastIndexOf('.') + 1));
str.delete(str.length() - 4, str.length());
str.setLength(str.length() - 4);
str.append('(');
if (extraArgs != null) {
str.append(extraArgs);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import java.util.Arrays;
import java.util.List;
import java.util.Iterator;

import io.burt.jmespath.Adapter;
import io.burt.jmespath.Expression;
Expand All @@ -22,15 +21,15 @@ protected Expression<T> operand(int index) {

@Override
protected String internalToString() {
if (operands.isEmpty()) {
return "";
}

StringBuilder operandsString = new StringBuilder();
Iterator<Expression<T>> operandIterator = operands.iterator();
while (operandIterator.hasNext()) {
Expression<T> operand = operandIterator.next();
operandsString.append(operand);
if (operandIterator.hasNext()) {
operandsString.append(", ");
}
for (Expression<T> operand : operands) {
operandsString.append(operand).append(", ");
}
operandsString.setLength(operandsString.length() - 2);
return operandsString.toString();
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package io.burt.jmespath.node;

import java.util.Iterator;
import java.util.List;

import io.burt.jmespath.Adapter;
Expand All @@ -19,12 +18,10 @@ protected String internalToString() {
return null;
} else {
StringBuilder buffer = new StringBuilder();
Iterator<Node<T>> iterator = nodes.iterator();
buffer.append(iterator.next());
while (iterator.hasNext()) {
buffer.append(", ");
buffer.append(iterator.next());
for (Node<T> node : nodes) {
buffer.append(node).append(", ");
}
buffer.setLength(buffer.length() - 2);
return buffer.toString();
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ public ParseException(String query, Iterable<ParseError> errors) {
private static String joinMessages(Iterable<ParseError> errors) {
StringBuilder s = new StringBuilder();
for (ParseError e : errors) {
s.append(String.format(", %s at position %d", e.message(), e.position()));
s.append(String.format("%s at position %d, ", e.message(), e.position()));
}
s.delete(0, 2);
s.setLength(s.length() - 2);
return s.toString();
}

Expand Down