Add uilaunchstoryboardname key to ios plist files #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like iOS uses this field to determine if the app is a modern one that can support new device sizes; without it, the app content has a large black margin at the top and bottom of the app.
I feel like this is a reasonable flag to add to all apps, given how I can't imagine any production app would want to run in legacy cropped mode, but happy to try to convert this into a configuration parameter if that's not the case.
I tested this change by bundling an app and running on an iPhone 12 mini, and making sure this change fixed the cropping issue.
Fixes #91
Thanks for the great project! It's been working very well for me so far.