Created the linux module to improve the code structure

[0x61nas]

Ceate a separate linux module and separate the common functions into one separated file

This PR is uncompleted yet, but I opened it to track the progress and to discussion.

I had to implement the Default trait for the Settings and the PackageSettings and the BundleSettings structs to create tests, but I'm not sure if this is the beast way or there are the best way to make this without implement the Default trait?

• Close: Project structure issue #129

TODO:

• Create a linux module and a common file for Linux
• move the deb_bundle into linux module
• move the rpm_bundle into linux module
• implement the Default traite for the Settings and the PackageSettings and the BundleSettings structs to create tests
• Create a test for the generate_desktop_file function
• Create a test for the tar_and_gzip_dir function, and refactor it if need it
• Create a test for the create_tar_from_dir function, and refactor it if need it (covered with the tar_and_gzip_dir function test)
• Create a test for the create_file_with_data function, and refactor it if need it
• Create a test for the total_dir_size function, and refactor it if need it
• Refactor the generate_icon_files function, and create unit-test for it
• Separate the generate_md5sum function from the deb_bundle.rs file to the common.rs file, and create a test for it

[SergioRibera]

@anas-elgarhy do you need help? I just discovered this project and was thinking that it would be a good idea to accommodate it a little better in order to be able to scale on the other bundle systems out there and I see that you are already working on it

[0x61nas]

Yes @SergioRibera, I'm not available now to work on code unfortunately, so I really appreciate if you can help me, and review this pr anaselgarhy#1 or if u fix the conflicts

And thanks in advance.

[0x61nas]

I had to remove the implementation of the Default trait for the Settings and the BundleSettings structs in older to merge the base, because @slonopotamus removed the PackageSettings struct in #138 and used the Package struct from the cargo_metadata crate which is not implementing the Default trait and I think is not ideal if I implemented it.

But I still need an easy way to create an instance from the Settings struct in a some tests. So maybe I go to use the test-context crate, or I'll break down the functions and methods that's needing the Settings struct into small inline functions/methods, and test them.

• Merging PR: Resolve the conflicts and merge the master branch anaselgarhy/cargo-bundle#3

[SergioRibera]

I had to remove the implementation of the trait for the and the structs in older to merge the base, because @slonopotamus removed the struct in #138 and used the struct from the crate which is not implementing the trait and I think is not ideal if I implemented it.Default``Settings``BundleSettings``PackageSettings``Package``cargo_metadata``Default

But I still need an easy way to create an instance from the struct in a some tests. So maybe I go to use the crate, or I'll break down the functions and methods that's needing the struct into small inline functions/methods, and test them.Settings``test-context``Settings

• Merging PR: Resolve the conflicts and merge the master branch anaselgarhy/cargo-bundle#3

I think I can help you here too, let me check out that pr and see if I can add some details

[0x61nas]

I think I can help you here too, let me check out that pr and see if I can add some details

Nice, u can also take a look at the test_generate_desktop_file test, because this is the only place I use the default in.

I wonder if this test is not quite important, and we can just remove it

[0x61nas]

I think it's a good idea to just ignore test generate_desktop_file function for now

[0x61nas]

The test action has a bug, It's using the stable rust, while we use nightly features

[0x61nas]

I can replace the assert_matches with the normal assert macro instead

[0x61nas]

@mdsteele Please don't forget to review this sad PR when you have a time

[0x61nas]