Client dockerfile #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a dockerfile for building the client container as a multistage nginx image for minimal size and full functionality. Include configuration files, but the implementation of loading config on build has to wait for react-scripts to be removed for access to the webpack config.
burtonr
force-pushed
the
client-dockerfile
branch
from
514b0ad
to
1712a2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dockerfile for running the client behind an Nginx proxy to ensure the minimal image size.
Configuration is currently only done in a single file, but will be updated when react-scripts is removed so that the config can be plugged in during compile/minification time.
Resolves #2