This repository has been archived by the owner on Mar 5, 2022. It is now read-only.
Fixed _buildAmazonS3Path in ImageProcessingListener #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for that well done commit! It has even tests. 👍 But are you aware that there are much better listeners and path builders available? You fixed legacy code that has already been flagged as deprecated and is going to be removed in 2.0. So I highly recommend you to switch to the new listeners in /src/Storage/. |
burzum
added a commit
that referenced
this pull request
Feb 24, 2016
Fixed _buildAmazonS3Path in ImageProcessingListener
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image object should be immutable, otherwise it returns incorrect path when building it more than once for same image (and image passed by reference).