Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(engine-loader): avoid stale
asset-loader
For some reason the injection of the `asset-loader` becomes "stale" in production builds. It seems like, the service is looked up first, then re-registered by a third-party and the injection is not updated. This causes the manifest to be empty and the loading to always fail. I have no idea what the root cause is, but this trivial change is safe and makes sure that we always look up the "feshest" version of the service.
- Loading branch information
d30931e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@buschtoens Thanks for this great addon! I believe this revision may have fixed an issue my team has been trying to solve, which is lazy loading a route-less engine within a lazy route engine...
It wasn't working before this version, and now it seems to be fixed. If I recall, the original issue was definitely something around the
const assetLoader = get(this, 'assetLoader')
not being available in our scenario. Seems like always looking up the "freshest" version fixed that.d30931e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbailey4 That's great to hear! Thank you. ❤️