.resample_id modification #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdancho84
added a commit
that referenced
this pull request
Mar 14, 2021
|
I modified your code a bit. I split into two tracks:
I can more easily control the output of what the user sees. This could probably be simplified even further but gets the desired result.
Here's the two types of result - summarized vs unsummarized.
|
|
Great, I see it a good solution. Thanks for sharing the explanation! |
|
Yep - just trying to pass along my thought-process. |
|
Cleaned it up a bit further.
|
|
This was a nice one! Well seen. Now I think will be difficult to further improve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mdancho84
I have adapted the
modeltime_resample_accuracy()function in order to return the .resample_id when thesummary_fnsis NULL as suggested in #1 Check if all is ok for youMy next objective is recursive :)
Regards