add polars backend to get_frequency_summary - first draft #271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a first draft.
It is working as is but I have two concerns:
_get_pandas_frequency is difficult to convert because there is currently no idx.inferred_freq equivalent in polars.
The only solution I can think of is to write an equivalent of inferred_freq pandas implementation, but I am not sure if it is worth the time.
I don't know what unit is expected for freq_median_timedelta.
Again, there is no timedelta in polars so I create it from _freq_median_seconds and put the unit to seconds.
But the output is probably not consistent with the pandas implementation then ?
Linked to #77