Skip to content
This repository has been archived by the owner on Jun 5, 2020. It is now read-only.

Update node-ffi for 0.12 compatibility #2

Merged
merged 2 commits into from Jul 10, 2015

Conversation

mroderick
Copy link
Contributor

node-ffi prior to 1.3 doesn't build with node@0.12

See node-ffi/node-ffi#187

This means that buster-ci doesn't build for node@0.12, and in turn that buster doesn't build for node@0.12.

Once this gets merged and published, we can create PRs for buster-ci and buster, and then finally publish an update to buster that will allow it to be used under node@0.12

node-ffi prior to v1.3 doesn't build with node 0.12

See node-ffi/node-ffi#187
To verify that there's actually compatiblity with node 0.12

The addition of `sudo: false` allows travis to use a different VM,
that starts much faster
cjohansen added a commit that referenced this pull request Jul 10, 2015
Update node-ffi for 0.12 compatibility
@cjohansen cjohansen merged commit 836cf53 into busterjs:master Jul 10, 2015
@cjohansen
Copy link
Member

👍

Maybe @dwittner can publish?

@mroderick mroderick deleted the update-ffi-dependency branch July 10, 2015 15:00
@dwittner
Copy link
Member

@mroderick, i just released version 0.1.5 of buster-ci-agent. Because the dependency to buster-ci-agent is specified as "~0.1" in buster-ci, the change will be immediately effective.

@mroderick
Copy link
Contributor Author

@dwittner thanks!

I have confirmed that buster now installs correctly under node@0.12

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants